Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix dark mode on storybook web Docs pages #193

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

narin
Copy link
Contributor

@narin narin commented Feb 21, 2024

Ticket #53

Description of Change

Quick fix to enable dark mode toggling on Docs pages. Dark mode was previously only working on the stories. This seems to be a known bug for Storybook. Found a workaround here. This also required renaming preview.ts to preview.tsx since it now includes React code.

Testing Packages

N/A (tested locally)

Screenshots/Video

Screen.Recording.2024-02-21.at.3.13.31.PM.mov

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

dependabot bot and others added 3 commits February 21, 2024 00:43
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@narin narin requested a review from a team as a code owner February 21, 2024 23:26
Copy link
Contributor

@TimRoe TimRoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving code-wise, but:

PR is linked to ticket(s)

doesn't seem satisfied in that the in-write-up link says ticket 53 but goes nowhere and the PR itself is connected to a storybook-dark-mode ticket that, while related, is not in our repo/shouldn't use the built in connection as this PR isn't closing out the storybook-dark-mode issue.

Since it's a small change, would be fine with it moving not linked to a ticket if an appropriate one hasn't actually been created.

@narin
Copy link
Contributor Author

narin commented Feb 22, 2024

Fixed link. Couldn't connect it to the issue since it was closed already. ZenHub automatically connected the referenced storybook issue. Removed the connection.

@narin narin merged commit a61d29f into main Feb 22, 2024
6 of 15 checks passed
@narin narin deleted the bug/narin-fix-docs-dark-mode branch February 22, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants