Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Space Force and Dark VA text logo to assets package #320

Merged
merged 3 commits into from
May 14, 2024

Conversation

narin
Copy link
Contributor

@narin narin commented May 14, 2024

Description of Change

Adds the following SVGs to the assets package:

  • Space Force Light
  • Space Force Dark
  • VA Logo with dark text

Testing Packages

N/A

Screenshots/Video

N/A

Testing

N/A

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin requested a review from a team as a code owner May 14, 2024 19:25
@narin narin merged commit 9995fe2 into main May 14, 2024
5 of 9 checks passed
@narin narin deleted the feature/304-nr-update-va-ussf-logos branch May 14, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants