Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Replace custom pagination implementation with va-pagination in content-build #14795

Closed
3 tasks
randimays opened this issue Aug 15, 2023 · 3 comments
Closed
3 tasks
Labels
Needs refining Issue status News release CMS managed product owned by Facilities team Pagination FE component Public Websites Scrum team in the Sitewide crew Resources and support CMS managed product owned by Public Websites team Story CMS managed product owned by Facilities team VA.gov frontend CMS team practice area

Comments

@randimays
Copy link
Contributor

randimays commented Aug 15, 2023

Description

There is a shared pagination template in content-build used by multiple templates. It is an older/custom implementation.

We should be using the va-pagination (web component) instead, if possible. DST guidance

User story

AS A Veteran
I WANT all pagination functionality to be consistently implemented throughout VA.gov
SO THAT the functionality is accessible, consistent and defects are minimized

Engineering notes / background

Several templates in content-build utilize this pagination template:

  • support_resources_article_listing

Analytics considerations

Quality / testing notes

Need to explore whether we can add unit testing for this (is it possible in CB?)

Acceptance criteria

  • support_resources_article_listing pagination functionality thoroughly tested
  • support_resources_article_listing pagination tested on mobile
  • Accessibility review
@randimays randimays added Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area labels Aug 15, 2023
@jilladams jilladams added Resources and support CMS managed product owned by Public Websites team Pagination FE component Story CMS managed product owned by Facilities team News release CMS managed product owned by Facilities team labels Jan 18, 2024
@jilladams
Copy link
Contributor

#14767 is complete, removed the lines below from ticket body:
These templates also use the pagination component, but the templates should be removed by #14767 as they appear to be unused.

If they are not removed by the time this ticket is picked up, we should omit making any fixes to these templates:
- bios_page
- events_page
- news_stories_page
- press_releases_page

@FranECross
Copy link

@laflannery Please close this when you make the new ticket for V3 component updates. Thanks!

@laflannery
Copy link
Contributor

Closing in favor of #16987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs refining Issue status News release CMS managed product owned by Facilities team Pagination FE component Public Websites Scrum team in the Sitewide crew Resources and support CMS managed product owned by Public Websites team Story CMS managed product owned by Facilities team VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants