Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1 & 3 Components] Upgrade V1 components to V3 for Resources & Support taxonomy term page #16987

Closed
4 tasks
FranECross opened this issue Jan 23, 2024 · 3 comments
Closed
4 tasks
Labels
Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 VA.gov frontend CMS team practice area

Comments

@FranECross
Copy link

FranECross commented Jan 23, 2024

Background

The Design team is migrating all V1 components to V3 on February 16, 2024, which means that the PW team needs to upgrade any of our products currently using V1 components to V3.

Example pages:

List of Components

V1 components without V3 equivalents

  1. Back to top: Currently using v1, which is the most up to date component

Elements that are not using components that should be (Backlog)

  1. Pagination
    • We are not using a component need to update to v3 component

Probably will be resolved with the Resources Landing page ticket but if not:

  1. Breadcrumbs
    • Not using any component but should be using v3
  2. Search input
  3. Radio buttons
    • There might be some technical limitations here, I'm not sure but if possible we should be using v3 components

Documentation

Sitewide V3 DS component review spreadsheet

User story

AS A PO/PM for the PW team products, as well as for the Design team
I WANT all V1 components to be upgraded to V3 either before or soon after February 16, 2024
SO THAT all PW products are in alignment with the new components.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • V3 components are now used for the features listed above, and display/function correctly
  • other features display correctly
  • verify/review the E2E tests
  • check desktop and mobile
@FranECross FranECross added Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area and removed Needs refining Issue status labels Jan 23, 2024
@laflannery
Copy link
Contributor

Adding Randi's notes from a previous ticket regarding the Pagination so when the element is updated to the component we don't lost these:

  • Several templates in content-build utilize this pagination template:
  • Need to explore whether we can add unit testing for this (is it possible in CB?)

@FranECross FranECross added the V3 Components Update to V3 label Feb 7, 2024
@chriskim2311 chriskim2311 changed the title [V3 Components] Upgrade V1 components to V3 for Resources & Support taxonomy term page [V1 & 3 Components] Upgrade V1 components to V3 for Resources & Support taxonomy term page Feb 23, 2024
@randimays
Copy link
Contributor

Marking as a dupe of #17199 & #16986. This can be closed.

@FranECross
Copy link
Author

Closing per note about duplicate above.

@FranECross FranECross closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

5 participants