Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1 & 3 Components] Implement available V1 or V3 components for Reusable Q&A with standalone page #17278

Closed
9 tasks
laflannery opened this issue Feb 19, 2024 · 3 comments
Labels
Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

laflannery commented Feb 19, 2024

Background

The Design team is releasing a Typography update (sometime in March), which means that the PW team needs to upgrade any of our products where components aren't currently being using, but a V1 or V3 component is available.

If the updates aren't made prior to the Typography update, there's a chance that Veteran-facing issues may occur.

Example pages:

Elements that are not using components that should be

  1. Link
    • We should be using the v1 component everywhere we can, including content inside accordions and other components
  2. Telephone
    • The component is not being used anywhere but should be, including inside accordions and other content

Possibly templated into all Resources & Support pages so may only need to be completed once

  1. Radio buttons
    • There are rating radio buttons that should be using v3 component
  2. Button
  3. Telephone
    • Within this reused section, the V1 component should be added into the "Need more help?" section

Might be resolved with the Resources Landing page ticket but if not:

  1. Search input
  2. Radio buttons
    • There might be some technical limitations here, I'm not sure but if possible we should be using v3 components

From #17001

User story

AS A PO/PM for Public Websites products
I WANT to implement available V1 or V3 components in features & products currently under Public Websites management where components aren't currently being used
SO THAT all PW products are in alignment with the current component version
AND Veterans and other users have a consistent experience throughout VA.gov tools and information

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • Link is is using V1 components
  • Telephone is using V1 components
  • Radio buttons are using V3 components (if not templated in the Resources & Support pages as noted above)
  • Button is using V3 components (if not templated in the Resources & Support pages as noted above)
  • Telephone is using V3 components (if not templated in the Resources & Support pages as noted above)
  • other features display correctly
  • verify/review the E2E tests
  • check desktop and mobile
  • a11y review
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 labels Feb 19, 2024
@FranECross FranECross changed the title [V1 & 3 Components] Implement available components for Reusable Q&A with standalone page [V1 & 3 Components] Implement available V1 or V3 components for Reusable Q&A with standalone page Feb 20, 2024
@randimays
Copy link
Contributor

The section below will be taken care of on #16986 & #17199. We can remove the search input and the search input's radio buttons from the requirements.

Screenshot 2024-02-28 at 10 29 29 AM

@FranECross FranECross removed the Needs refining Issue status label Feb 28, 2024
@laflannery
Copy link
Contributor Author

laflannery commented Mar 20, 2024

@Randi @FranECross @jilladams I believe we can close this one too (as we did Step-by-step and FAQs) because everything remaining here is CMS content that we cannot convert to components

@FranECross
Copy link

Closing per Laura's comment above.

@FranECross FranECross closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants