Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1 & 3 Components] Implement available components for Resources & Support landing page #16986

Closed
7 of 9 tasks
FranECross opened this issue Jan 23, 2024 · 5 comments
Closed
7 of 9 tasks
Assignees
Labels
Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 VA.gov frontend CMS team practice area

Comments

@FranECross
Copy link

FranECross commented Jan 23, 2024

Background

The Design team is releasing a Typography update (sometime in March), which means that the PW team needs to upgrade any of our products where components aren't currently being using, but a V1 or V3 component is available.

If the updates aren't made prior to the Typography update, there's a chance that Veteran-facing issues may occur.

The following have been identified by Laura Flannery:

Resources Landing Page

Elements that are not using components that should be

  1. Breadcrumbs Covered by Spike: Breadcrumbs for content-build and impact of USWDS V3 component #17162
    - Not using any component but should be using v3
  2. Link
  3. Search input
  4. Radio buttons
    • There might be some technical limitations here, I'm not sure but if possible we should be using v3 components
  5. Button

Documentation

Sitewide V3 DS component review spreadsheet

User story

AS A PO/PM for Public Websites products
I WANT to implement available V1 or V3 components in features & products currently under Public Websites management where components aren't currently being used
SO THAT all PW products are in alignment with the current component version
AND Veterans and other users have a consistent experience throughout VA.gov tools and information

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • Breadcrumbs are using V3
  • Link is using V1
  • Search is using V3
  • Radio button is using V3
  • Buttons are using V3
  • other features display correctly
  • verify/review the E2E tests
  • check desktop and mobile
  • a11y review
@FranECross FranECross added Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area and removed Needs refining Issue status labels Jan 23, 2024
@laflannery laflannery changed the title [V3 Components] Upgrade V1 components to V3 for Resources & Support landing page (/resources) [V3 Components] Upgrade V1 components to V3 for Resources & Support landing page Jan 26, 2024
@FranECross FranECross added the V3 Components Update to V3 label Feb 7, 2024
@FranECross FranECross changed the title [V3 Components] Upgrade V1 components to V3 for Resources & Support landing page [V3 Components] Implement available V3 components for the Resources & Support landing page Feb 13, 2024
@FranECross FranECross changed the title [V3 Components] Implement available V3 components for the Resources & Support landing page [V3 Components] Implement available components for the Resources & Support landing page Feb 15, 2024
@FranECross FranECross changed the title [V3 Components] Implement available components for the Resources & Support landing page [V1 & 3 Components] Implement available components for the Resources & Support landing page Feb 15, 2024
@laflannery laflannery changed the title [V1 & 3 Components] Implement available components for the Resources & Support landing page [V1 & 3 Components] Implement available components for Resources & Support landing page Feb 19, 2024
@randimays randimays self-assigned this Feb 21, 2024
@randimays
Copy link
Contributor

@FranECross @jilladams Can I remove breadcrumbs from the scope of this ticket, given that we have #17162?

@jilladams
Copy link
Contributor

Yep - we confirmed that yesterday live. Making the change here.

@randimays
Copy link
Contributor

I am working on this one plus #17199. Struggling with pagination (from #17199) as the v3 component has elements in the shadow DOM, and we have to add a click handler to change the pages and can't access the shadow DOM elements. I have been communicating with Jami from the DST about it here: https://dsva.slack.com/archives/C01DBGX4P45/p1708967336736359 hopefully we can find a solution!

All other components have been completed, but we still need an accessibility review of everything once it's complete.

@randimays
Copy link
Contributor

Update: The PR (department-of-veterans-affairs/vets-website#28236) is ready for review. It excludes any web component updates for <button>. There is a single <button> used for the expand/collapse behavior on mobile:
Screenshot 2024-03-01 at 10 24 56 AM

This does not need to be converted to a web component as it is stylistically very different from the web component. I have request an accessibility review that we can hopefully get on Monday when Laura returns from PTO.

@randimays
Copy link
Contributor

Accessibility review is completed and the changes are verified in production. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew V3 Components Update to V3 VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants