Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15155: Updates the naming schema for VBA, splits with NCA #17972

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Apr 26, 2024

Description

Relates to #15155

Testing done

Manually

Screenshots

Screenshot 2024-04-26 at 7 35 29 AM

QA steps

Set up QA Content Publisher as a VBA Editor

  • As an admin, assign the following roles to QA Content Publisher
    • Content creator - VBA
    • Content publisher
  • Assign the following Sections to QA Content Publisher
    • Cheyenne VA Regional Benefit Office

Test NCA URL

  • As an admin (as we don't have an NCA role at present), publish an NCA facility currently in draft
  • Confirm that the URL is following the previously established/not yet CAIA-approved naming schema

Test VBA URL

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 26, 2024 12:39 Destroyed
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@omahane omahane force-pushed the VACMS-15155-vba-facility-alias-pattern branch from 6d065fd to 6b43b12 Compare April 26, 2024 13:06
@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 26, 2024 13:07 Destroyed
@omahane omahane marked this pull request as ready for review April 26, 2024 13:07
@omahane omahane requested a review from a team as a code owner April 26, 2024 13:07
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Apr 26, 2024
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and QA steps passed.

Screenshot 2024-04-26 at 10 11 38 AM

@davidmpickett
Copy link
Contributor

davidmpickett commented Apr 26, 2024

QA passes

  • Something I noticed that's not part of the ACs - the NCA Node view doesn't seem to have the VA URL slot in the right-hand column. Might be a backlog issue

VBA facility URLs update to correct format upon publishing

Screenshot 2024-04-26 at 11 54 23 AM

Screenshot 2024-04-26 at 11 54 51 AM

NCA facilities retain existing format upon publishing

Screenshot 2024-04-26 at 11 55 52 AM

Screenshot 2024-04-26 at 11 56 18 AM

@omahane
Copy link
Contributor Author

omahane commented Apr 26, 2024

@davidmpickett After a bit of digging around, I think that the reason NCA facility doesn't produce a link while VBA facility does has to do with this form (staging link posted because prod is being updated): https://staging.cms.va.gov/admin/config/content/exclusion-types-form

Screenshot 2024-04-26 at 14 41 48

@omahane omahane merged commit 88f21dd into main Apr 26, 2024
26 checks passed
@omahane omahane deleted the VACMS-15155-vba-facility-alias-pattern branch April 26, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants