Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16825: Aligns type of buttons for adding servc loc #18119

Merged
merged 1 commit into from
May 14, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented May 14, 2024

Description

Relates to #16825

Testing done

Manually

Screenshots

Screenshot 2024-05-14 at 11 52 40 AM

QA steps

Set up QA Content Publisher

  • As an admin, update the QA Content Publisher
    • Assign the following roles
      • Content creator - VAMC
      • Content creator - VBA
      • Content publisher
    • Assign the following Section
      • VA Boston health care
      • Cheyenne VA Regional Benefit Office

Edit a VAMC Facility Health Service

Edit a VAMC Facility Non-clinical Service

Edit a VBA Facility Service

Edit a Service Region

Confirm consistency

  • Confirm that all 4 of these "Add Service location" buttons look the same

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 14, 2024 16:18 Destroyed
@omahane omahane force-pushed the VACMS-16825-align-add-service-location-buttons branch from 4c9f23b to 8c540e6 Compare May 14, 2024 16:31
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 14, 2024 16:31 Destroyed
@omahane omahane marked this pull request as ready for review May 14, 2024 16:56
@omahane omahane requested a review from a team as a code owner May 14, 2024 16:56
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label May 14, 2024
Copy link
Contributor

@davidmpickett davidmpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA passes and config changes are straightforward. Approved

Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons all the way down!

@omahane omahane merged commit 8358cd3 into main May 14, 2024
30 checks passed
@omahane omahane deleted the VACMS-16825-align-add-service-location-buttons branch May 14, 2024 19:40
@davidmpickett
Copy link
Contributor

Moving to prod verification since we have to wait until daily CMS deploy to verify and there's not ticket tracking that otherwise

@davidmpickett
Copy link
Contributor

Verified on prod for all four instances
Screenshot 2024-05-15 at 4 12 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants