-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule to warn not to migrate certain models #1027
Conversation
Wanted to point out in the screenshot it does show both "upgrade this component" and "DO NOT upgrade this component" messages. I could make it so it only shows the correct one, but it would require pulling the |
Are there any other usages of the |
How does this work? Is there a corresponding vets-website PR? |
Description
Add a warning not to migrate React Modals that need to remain for the injected header. This will only show in certain directories based on
.eslintrc
files invets-website
.Partial Injected Header - Add eslint warning & inline comments for React Modals that should not be touched#2541
Testing done
Added test. Tested eslint in vet-website locally.
Screenshots
Acceptance criteria
Definition of done