Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out eslint rule around aliasing until Cypress is reconfigured… #1028

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Comment out eslint rule around aliasing until Cypress is reconfigured… #1028

merged 1 commit into from
Apr 11, 2024

Conversation

CBonade
Copy link
Contributor

@CBonade CBonade commented Apr 11, 2024

Summary

  • disables the linting rule throwing warnings for aliases not being used that are not supported by Cypress. This was commented as we should reimplement it once Cypress config is adjusted to support these aliases and we make an effort to correct these. However in the interim, these warnings number in the thousands and is likely slowing down CI.

@CBonade CBonade requested a review from a team as a code owner April 11, 2024 16:21
@CBonade CBonade merged commit 0a8fbad into master Apr 11, 2024
5 of 6 checks passed
@CBonade CBonade deleted the disable-alias-linting branch April 11, 2024 16:32
@ataker ataker mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhill pjhill pjhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CBonade @pjhill