Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint rule for the ExpandingGroup React component #907

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Feb 17, 2023

Description

This will add a warning for the ExpandingGroup React component's deprecation.

The warning message will read:

The ExpandingGroup React component is deprecated. Please replace with a custom solution. Also note that the wizard pattern is deprecated as well. See "Retrofit this pattern" for additional guidance if needed: https://design.va.gov/patterns/wizards#retrofit-this-pattern

Screenshot 2023-02-17 at 10 04 52 AM

Related issue: department-of-veterans-affairs/vets-design-system-documentation#1378

Testing done

VS Code
vets-website locally

Screenshot 2023-02-17 at 10 19 38 AM

Acceptance criteria

  • A ESLint warning message displays where the ExpandingGroup react component is used.

Definition of done

  • Changes have been tested in vets-website
  • Changes have been tested in IE11, if applicable
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@jamigibbs jamigibbs merged commit 152a408 into master Feb 17, 2023
@jamigibbs jamigibbs deleted the 1378-eslint-rule-expanding-group branch February 17, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants