Remove .usa-button focus background color override #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jhonnyoddball
approved these changes
Mar 6, 2023
jamigibbs
commented
Mar 8, 2023
| @@ -7,6 +7,8 @@ button, | |||
| [type='submit'], | |||
| [type='reset'], | |||
| [type='image'] { | |||
| -webkit-font-smoothing: inherit; | |||
| -moz-osx-font-smoothing: inherit; | |||
There was a problem hiding this comment.
I've update this to inherit because this seems to be what the USWDS v3 system uses for their no-knockout-font-smoothing mixin:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update will remove a custom override to .usa-button that was applying a focus background color that does not conform with the design system button states. The focus color should be --color-primary-darker (#003e73); the same as va-button.
Related issue: department-of-veterans-affairs/vets-design-system-documentation#1585
Related PR: department-of-veterans-affairs/component-library#642
Testing done
Locally
Screenshots
Acceptance criteria
Definition of done