Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process List] Circle fix for numbers #911

Merged
merged 3 commits into from
May 19, 2023

Conversation

josephrlee
Copy link
Contributor

@josephrlee josephrlee commented Mar 10, 2023

Description

Added a fix to address this issue to get the circle background in for each numbered list item to show as a real circle rather than the ovalish thing that it is now:

closes department-of-veterans-affairs/vets-design-system-documentation#1596

Testing done

Tested in browser inspector mode in chrome

Screenshots

Acceptance criteria

  • [ ]

Definition of done

  • Changes have been tested in vets-website
  • Changes have been tested in IE11, if applicable
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Added a fix to address this issue to get the circle background in for each numbered list item to show as a real circle rather than an ovalish thing that it is now: department-of-veterans-affairs/vets-design-system-documentation#1596
@josephrlee josephrlee requested a review from a team as a code owner March 10, 2023 22:46
Copy link
Contributor

@jamigibbs jamigibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Thank you for submitting this update. 👍

@jamigibbs
Copy link
Contributor

@josephrlee I am going to merge this on your behalf so that we can create a new Formation release. 🙏

@jamigibbs jamigibbs merged commit 2a6e42a into master May 19, 2023
6 checks passed
@jamigibbs jamigibbs deleted the josephlee-process-list-circle-patch branch May 19, 2023 15:15
@josephrlee
Copy link
Contributor Author

Just seeing this now, no worries! Glad my fix works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process List css bug
2 participants