Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Replace babel-eslint with @babel/eslint-parser #931

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

acald-creator
Copy link
Contributor

@acald-creator acald-creator commented May 25, 2023

Description

In two different repos as I have found uses babel-eslint.

  • vets-website
  • veterans-facing-services-tools

Please see the package at https://www.npmjs.com/package/babel-eslint which suggests using @babel/eslint-parser.

Why do we need this updated?

  • The package babel-eslint has been deprecated and has not been active for 3 years now. It has been deprecated in favor of @babel/eslint-parser.
  • The package also has not been receiving maintenance and also no updates either.
  • This will also help anyone in the future that wants to create a new repo and would like to utilize the @department-of-veterans-affairs/recommended eslint plugin.
  • For our Identity team, we are creating our own Sign-in-Service dashboard, it would be great to be able to take small steps to update and replace this deprecated package with the current package.

Testing done

There seems to be no negative effect in updating babel-eslint with @babel/eslint-parser in veterans-facing-services-tools, but this has not been tested in vets-website, though I would like to update this as well.

There is a pair PR in vets-website: department-of-veterans-affairs/vets-website#24355

Link to Zenhub issue: https://app.zenhub.com/workspaces/identity-5f5bab705a94c9001ba33734/issues/gh/department-of-veterans-affairs/va.gov-team/59030

Screenshots

Acceptance criteria

  • [ ]

Definition of done

  • Changes have been tested in vets-website
  • Changes have been tested in IE11, if applicable
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@acald-creator
Copy link
Contributor Author

Could we get this approved and merged?

This has been done in vets-website: department-of-veterans-affairs/vets-website#25105

@acald-creator acald-creator merged commit 051433e into master Aug 28, 2023
6 checks passed
@acald-creator acald-creator deleted the 59030-replace-babel-eslint branch August 28, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants