Replacing color-warning-message color name #978
Conversation
New color name is color-feedback-warning-background
| @@ -105,7 +105,7 @@ $color-primary-alt-darkest: #046b99; | |||
| $color-green-darker: #195c27; | |||
| $color-va-accent: #988530; // New gold "metal" acccent | |||
| $color-gold: #fdb81e; | |||
| $color-warning-message: #fac922; // Used for Disability benefits | |||
There was a problem hiding this comment.
This variable is being used in vets-website still. I'm wondering what would be the best way to do this changeover so they aren't interrupted.
Maybe we need to keep this variable here for now and add $color-feedback-warning-background too? Then update vets-website after it's available?
There was a problem hiding this comment.
For what it's worth, I'm changing this in vets-website right now, too, so there won't be any interruption. That PR should be up in the next few minutes.
There was a problem hiding this comment.
This repo is not directly linked to vets-website so just merging the PR won't make it available there. A new release of Formation will need to be created with this change and vets-website updated with the new version too (in your PR there would probably be easiest).
Before this PR is merged, you'll need to update the package.json version number and then follow step 3 in the docs for publishing Formation.
There was a problem hiding this comment.
Hmm, looks like you were right, I can't make the change in vets-website until after I've made that variable available in formation. So we either have to publish the new version of formation and then bring it in at the same time as the variable name change, or make both variables available in formation, bring it in and change vets-website, and then remove it from formation and publish another release. My preference would be to just publish a new formation release once, personally.
There was a problem hiding this comment.
My preference would be to just publish a new formation release once
yeah, I agree. It would be a hassle to make more than one release.
publish the new version of formation and then bring it in at the same time as the variable name change
That feels like the most straightforward approach. 🚀
There was a problem hiding this comment.
Version bumped, I believe the PR needs to be merged into master before I can publish.
Description
Relates to #2047.
Changes the name of color-warning-message to color-feedback-warning-background.
Testing done
Tested locally; builds OK, and passes tests.
Screenshots
No visual changes.
Acceptance criteria
Definition of done