Audit _shame.scss #992
Merged
Audit _shame.scss #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamigibbs
reviewed
Nov 15, 2023
There was a problem hiding this comment.
-
Is this bit only for IE support? If so, we might be able to remove it too since we no longer support that browser:
veteran-facing-services-tools/packages/formation/sass/_shame.scss
Lines 189 to 192 in 04bd7ce
-
And if we're creating a release after this, package.json version will need to be updated.
micahchiang
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
looks good, thanks for taking care of this @ataker! I just left one comment about the edit-checkbox styles.
Andrew565
reviewed
Nov 15, 2023
ataker
commented
Nov 15, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@department-of-veterans-affairs/formation", | |||
| "version": "7.1.0-color-beta", | |||
| "version": "8.0.0", | |||
There was a problem hiding this comment.
Bumped major version since removing could be a breaking change. Let me know if you disagree
jamigibbs
approved these changes
Nov 15, 2023
Andrew565
approved these changes
Nov 16, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete an audit of
_shame.scss. Remove unused code and add comments to code remaining about its use.Closes Audit _shame.scss
Testing done
Almost none, only removed code that had no use in
vets-websiteorcontent-build. Some I ran to double check an edge case, but mostly untested.Acceptance criteria
Definition of done