Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Font Awesome to v5.15.4 #996

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Update Font Awesome to v5.15.4 #996

merged 3 commits into from
Nov 30, 2023

Conversation

jamigibbs
Copy link
Contributor

Description

This updates the Font Awesome version to the latest available release.

related department-of-veterans-affairs/vets-design-system-documentation#2280

Testing done

Tested using Verdacio locally. I confirmed that before this update, the icon fa-phone-alt did not display in vets-website and after making this update, it displayed.

Screenshots

Tested in vets-website locally

Screenshot 2023-11-29 at 3 09 56 PM

Acceptance criteria

  • [ ]

Definition of done

  • Changes have been tested in vets-website
  • Changes have been tested in IE11, if applicable
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@jamigibbs jamigibbs marked this pull request as ready for review November 29, 2023 21:18
@jamigibbs jamigibbs requested a review from a team as a code owner November 29, 2023 21:18
@jamigibbs jamigibbs merged commit 6e5cb5d into master Nov 30, 2023
6 checks passed
@jamigibbs jamigibbs deleted the update-font-awesome branch November 30, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants