Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Va-Memorable-Date Web Component: Default Error Messages Overwrite Custom Error Messages #2856

Closed
2 of 6 tasks
adam-antonioli opened this issue May 22, 2024 · 8 comments · Fixed by department-of-veterans-affairs/component-library#1208
Assignees

Comments

@adam-antonioli
Copy link

adam-antonioli commented May 22, 2024

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

For the va-memorable-date web component under certain conditions, the custom error messages are getting overwritten by the component's default error messages.

Example

Screen.Recording.2024-05-22.at.09.27.16.mov

What I expected to happen

For the va-memorable-date web component, the custom error messages should overwrite the component's default error messages.

Steps to reproduce:

  1. Implement a va-memorable-date web component in a form with custom validation following the method described here.
  2. Specifically, implement validation which conflicts with the existing default validation. For example: Check if the month is within the expected number range of 1<=n<=12 on an onBlur event and display an error, such as "My error".
  3. Observe that the default validation is what is displayed instead of the custom validation ("My error").

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

Related ticket with additional information: https://dsva.slack.com/archives/CBU0KDSB1/p1715885793285659?thread_ts=1715787286.085509&cid=CBU0KDSB1

@caw310
Copy link
Contributor

caw310 commented May 22, 2024

@MichelleDieudonne
Copy link

@caw310 I see that you have added this to your planning, do you have an estimate for when this bug will be worked? Right now this blocking some of our PI committed functional work. Thank you!

@caw310
Copy link
Contributor

caw310 commented May 23, 2024

@MichelleDieudonne No estimate on when we will get to this. Hoping in the next sprint or two. However, we have our sprints planned out working on the upgrade.

@MichelleDieudonne
Copy link

@caw310 Good Morning! Checking back in to see if all were able to decide when you will be pulling this item for work. We are approaching the end of our PI and since this is a committed item for us we will need to determine our next steps based on your response. Thank you!

@caw310
Copy link
Contributor

caw310 commented Jun 7, 2024

@MichelleDieudonne This is tentatively scheduled to be worked on in our next sprint which starts June 20.

@Mottie
Copy link

Mottie commented Jun 17, 2024

@MichelleDieudonne
Copy link

@Mottie with the related ticket linked above, will this issue be fixed during this sprint? We are coming to the end of our PI and need to know how to communicate to our customer around our work that this is affecting. Thank you!

@caw310
Copy link
Contributor

caw310 commented Jun 20, 2024

We had to move this to the next sprint due to other higher priority work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants