VYE-226 Address/Direct Deposit schemas for verify your enrollment #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st currently failing
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New schema
New Schemas have been created for the App Verify Your Enrollment.
Change of Address Schema allows students that use Verify Your Enrollment the ability to update their address in BDN
Change of Direct Deposit allows students that use Verify Your Enrollment the ability to update their bank information in BDN
**BDN is the database that Verify Your Enrollment uses as its source of truth. BDN is an older database and does not communicate with other databases used on va.gov. Because of that, we have to make sure VYE users have a way to update their address and bank information. This is why we are creating new schemas for VYE instead of utilizing the VAs profile.
Please ensure you have incremented the version in
package.json.-Version set to 21.0.0 since this adds two new schemas
JIRA TICKET for SCHEMAs-> https://jira.devops.va.gov/browse/VYE-226
Pull Requests to update the schema in related repositories
After you've merged your changes to vets-json-schema you'll need to make PR's to vets-website and vets-api. Please link them here.
VETS-API PR -> As soon as this PR is approved and merge we will create the VETS-API PR with the new build pointing to the master hash commit of the updated JSON-SCHEMA
DRAFT PR that will be rebuilt once JSON-SCHEMA is in master -> https://github.com/department-of-veterans-affairs/vets-api/pull/15755/files
VETS-Website PR -> department-of-veterans-affairs/vets-website#28291
Once JSON-SCHEMA is in master, will double check the right hash commit is in the package.json. If need we will update.