Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow empty cards to be added #3434

Closed
akainic opened this issue Oct 18, 2016 · 2 comments
Closed

Do not allow empty cards to be added #3434

akainic opened this issue Oct 18, 2016 · 2 comments

Comments

@akainic
Copy link
Contributor

akainic commented Oct 18, 2016

Currently we allow users to submit blank entries for Employment and Education history. This is good. But we're also allowing users to add a new record without completing any data.

For places where you can add additional entries (periods of service, employment periods, etc.):

We should require at least one field to be filled before they add a new record. If not true, scroll up an display an error that says, "Fill out this record before adding a new one." (Or maybe just scroll up with no message?)

@kellymiller6
Copy link

Hi there! I’m a first-time contributor and was hoping to help out with this issue. I noticed nobody was assigned to it, but if there’s already a solution in progress I’m happy to try helping out elsewhere. Thanks!

@rtluu
Copy link

rtluu commented Aug 31, 2017

this is partially prevented and doesn't seem to be causing any problems. closing

@rtluu rtluu closed this as completed Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants