Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sciunit vcs checkin more robust #35

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Make sciunit vcs checkin more robust #35

merged 3 commits into from
Jan 31, 2024

Conversation

charmoniumQ
Copy link
Contributor

Fixes #31

@moazreyad
Copy link
Member

Thank you for the PR.

I wonder why the check-in and check-out are implemented with subprocess instead of Python's tarfile module. Unless there is a reason for that, I would propose using Python's native tarfile module to make the check-in and check-out more portable and leave the handling of OS details to Python.

@charmoniumQ
Copy link
Contributor Author

tarfile can be slower since it is pure-Python, but it is certainly more portable/predictable.

@sranasir sranasir merged commit a4f2018 into depaul-dice:master Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranasir sranasir sranasir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sciunit fails with invalid literal for int() with base 10
3 participants
@charmoniumQ @moazreyad @sranasir