-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a solution to declare peer dependencies #130
Comments
I follow the pattern from eslint-config-airbnb. They mark react as peer dependency. There is some discussions to remove the peer dependency or split the package into three sub-packages. In my option, those UMET warnings are fine because they are warnings not errors. I could like to keep this open and wait for a better idea/solution. |
Because the peer dependencies is blocking However, let us keep this open and find a better solution to resolve these optional peer dependencies. |
try to use |
Is this still an issue? I'm not even sure I understand what's going on to be honest. |
|
npm@2
is installing the peer dependencies which is an unexpected behavior, as they are optional fordepcheck
, and this means when usingnpm@2
, they are always installed.npm@3
won't install them, but gives unexpected warnings:I feel like the feature of using the dependencies when they are available is great, but instead of including them as peer dependencies, just include instructions in the docs what users need to do.
The text was updated successfully, but these errors were encountered: