Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the peer dependency. #133

Merged
merged 2 commits into from
Apr 1, 2016

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Mar 31, 2016

It is blocking npm shrinkwrap (dylang/npm-check#108) caused by NPM bug (npm/npm#10836).

However, keep #130 open to find a better solution for optional peer dependencies management.

It is blocking `npm shrinkwrap` caused by NPM bug.
@codecov-io
Copy link

Current coverage is 96.31%

Merging #133 into master will not affect coverage as of 044640e

@@            master    #133   diff @@
======================================
  Files           24      24       
  Stmts          515     515       
  Branches       101     101       
  Methods          0       0       
======================================
  Hit            496     496       
  Partial         10      10       
  Missed           9       9       

Review entire Coverage Diff as of 044640e

Powered by Codecov. Updated on successful CI builds.

@lijunle lijunle merged commit 9085c70 into depcheck:master Apr 1, 2016
@lijunle lijunle deleted the remove-peer-dependencies branch April 1, 2016 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants