Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positiv husky #315

Closed
VincentLanglet opened this issue Feb 7, 2019 · 7 comments · Fixed by #453
Closed

False positiv husky #315

VincentLanglet opened this issue Feb 7, 2019 · 7 comments · Fixed by #453

Comments

@VincentLanglet
Copy link
Contributor

Bug Description

Unused devDependencies

Code snippets

Used in the package json.

"husky": {
    "hooks": {
      "pre-commit": "yarn tsc && yarn lint-staged"
    }
  },

Versions

  • node -v: 11.6.0
  • npm -v: 6.5.0-next.0
  • depcheck --version: 0.7.1
@stale
Copy link

stale bot commented Nov 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 2, 2019
@VincentLanglet
Copy link
Contributor Author

This still should be fixed

@stale stale bot removed the wontfix label Nov 2, 2019
rumpl added a commit that referenced this issue Nov 2, 2019
rumpl added a commit that referenced this issue Nov 2, 2019
@rumpl rumpl closed this as completed in #453 Nov 2, 2019
@rumpl
Copy link
Member

rumpl commented Nov 2, 2019

Fixed, merged, will be available in the next release

Thank you for your patience.

@rumpl
Copy link
Member

rumpl commented Nov 2, 2019

@VincentLanglet if you want, you can make the PR to DefinitelyTyped once I release this

@VincentLanglet
Copy link
Contributor Author

@rumpl I can, (and will do the same for lint-staged).

What about including the types in this project ?
The file https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/depcheck/index.d.ts is not big, the update would be easier.

@rumpl
Copy link
Member

rumpl commented Nov 2, 2019

Yeah sure, we can include it, I have no idea how that works, we just publish depcheck with this .d.ts file and we are good to go?

@VincentLanglet
Copy link
Contributor Author

@rumpl I think this (#458) is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants