Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive eslint-config-prettier eslint-plugin-prettier #316

Closed
VincentLanglet opened this issue Feb 7, 2019 · 2 comments · Fixed by #326
Closed

False positive eslint-config-prettier eslint-plugin-prettier #316

VincentLanglet opened this issue Feb 7, 2019 · 2 comments · Fixed by #326
Labels

Comments

@VincentLanglet
Copy link
Contributor

Bug Description

Unused devDependencies

Code snippets

Used in the package json.

"eslintConfig": {
    "extends": [
      "react-app",
      "plugin:prettier/recommended"
    ]
  },

Versions

  • node -v: 11.6.0
  • npm -v: 6.5.0-next.0
  • depcheck --version: 0.7.1
@rumpl rumpl added the bug label Feb 14, 2019
@cyrilchapon
Copy link

I think I found why.

Specifying the eslint config inside package.json esLintConfig leads to false positive, whereas using a .eslintrc file with exact same config seems to trigger the special mode "eslint" which ignores those files

@cyrilchapon
Copy link

Exact same additional bug : the package.json "parser": "babel-eslint" (be it at the root of package.json or inside esLintConfig leads to babel-eslint being reported.

This is not the case when set inside .eslintrc file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants