Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: add support for package.json configuration #326

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

43081j
Copy link
Member

@43081j 43081j commented Mar 4, 2019

fixes #316.

adds support for eslintConfig in package.json which is supported by ESLint alongside the usual .eslintrc* files.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #326 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage    98.4%   98.41%   +0.01%     
==========================================
  Files          32       32              
  Lines         563      569       +6     
==========================================
+ Hits          554      560       +6     
  Misses          9        9
Impacted Files Coverage Δ
src/special/eslint.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3190ced...fa2ca3c. Read the comment docs.

@rumpl rumpl merged commit 4a85a2c into depcheck:master Mar 5, 2019
@rumpl
Copy link
Member

rumpl commented Mar 5, 2019

👍

@43081j 43081j deleted the eslint-package-json branch March 5, 2019 08:10
@cyrilchapon
Copy link

Is parser: babel-config (at the root of package.json) supported ?

@43081j
Copy link
Member Author

43081j commented Mar 5, 2019

@cyrilchapon as far as i can see, the correct way to specify an eslint parser in your package manifest should be:

{
  "eslintConfig": {
    "parser": "babel-eslint"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive eslint-config-prettier eslint-plugin-prettier
3 participants