Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False alert on vue-click-outside #361

Closed
tiagoppinho opened this issue Jul 1, 2019 · 7 comments · Fixed by #362
Closed

False alert on vue-click-outside #361

tiagoppinho opened this issue Jul 1, 2019 · 7 comments · Fixed by #362

Comments

@tiagoppinho
Copy link

tiagoppinho commented Jul 1, 2019

There is a false alert of unused dependency when using vue-click-outside.

Usage

import ClickOutside from 'vue-click-outside'

export default {
  name: 'Dropdown',
  directives: {
    ClickOutside
  },
  props: {
    ...
  },
  data () {
    return {
      ...
    }
  }
}

Depcheck json output

{
  "dependencies": ["vue-click-outside"],
  "devDependencies": [
    ...
  ],
  "missing": {},
  "using": {
    ...
  },
  "invalidFiles": {
    ...
  },
  "invalidDirs": {}
}
@rumpl
Copy link
Member

rumpl commented Jul 1, 2019

Thanks for reporting this, could you paste the whole output of depcheck json?

Even better, if this is an open source project could you give us the link?

If not, would it be possible for you to make a small repo that reproduces this error? When dealing with things like webpack, vue and others it's usually a problem with configuration files that depcheck can't read.

Cheers.

@tiagoppinho
Copy link
Author

Well, you can see the project itself and test it!

Here is the project, to test the depcheck you will have to go to the Frontend component available at src/main/frontend.

Cheers.

@rumpl
Copy link
Member

rumpl commented Jul 1, 2019

Nice! Gotta love open source! :)

rumpl added a commit that referenced this issue Jul 2, 2019
vue-template-compiler was in the devDependencies and didn't end up in
the released artifact giving way to weird unused dependencies issues

Fixes #361
@rumpl
Copy link
Member

rumpl commented Jul 2, 2019

@tiagoppinho This is hopefully fixed with my PR, will release a new version and you can tell me if it fixes stuff for you.

Cheers!

@tiagoppinho
Copy link
Author

@rumpl Thanks! Will update this issue once that PR gets merged and I test it on the project.

@rumpl rumpl closed this as completed in #362 Jul 3, 2019
rumpl added a commit that referenced this issue Jul 3, 2019
vue-template-compiler was in the devDependencies and didn't end up in
the released artifact giving way to weird unused dependencies issues

Fixes #361
@rumpl
Copy link
Member

rumpl commented Jul 3, 2019

I just pushed the 0.8.2 tag, it will soon be available on npm

@rumpl rumpl reopened this Jul 3, 2019
@tiagoppinho
Copy link
Author

After testing it on the project I think this issue is resolved. If I see some other problem I'll report it creating another issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants