Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-arrange file structure. #104

Merged
merged 6 commits into from
Feb 27, 2016
Merged

Re-arrange file structure. #104

merged 6 commits into from
Feb 27, 2016

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Feb 27, 2016

  • Split the file base on its functionality.
  • Merge the small util files back to the logic file.
  • Rename the load util to evaluate.
  • Write full function style in component exports.
  • Some refinements using lodash package.
  • TODO abstract the high order control flow as a util.

@lijunle
Split the constants to another file.
9431358
@lijunle
Split the check logic to a separated file.
55448d3
@lijunle
Merge three small utilities back to logic file.
dd10fe5 
- output -> cli (as print)
- get-node -> check
- discover-property-dep -> check
@lijunle
Rename a utility file.
4398456 
- load -> evaluate
- update the reference call.
@lijunle
Use lodash to refine some implementations.
c4673b5 
- Use lodash.isArray to replace instanceof expression.
- Use lodash.isEmpty to check empty array or object.
- Some refinements about the CLI logic.
@lijunle
Write full function style in component exports.
9e81c3a
@lijunle lijunle added this to the 0.6.1 milestone Feb 27, 2016
@codecov-io
Copy link

Current coverage is 97.05%

Merging #104 into master will decrease coverage by -0.50% as of 95d40ef

@@            master    #104   diff @@
======================================
  Files           16      18     +2
  Stmts          327     339    +12
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit            319     329    +10
  Partial          5       5       
- Missed           3       5     +2

Review entire Coverage Diff as of 95d40ef

Powered by Codecov. Updated on successful CI builds.

lijunle added a commit that referenced this pull request Feb 27, 2016
@lijunle
Merge pull request #104 from lijunle/arrange-files
a632b37 
Re-arrange file structure.
@lijunle lijunle merged commit a632b37 into depcheck:master Feb 27, 2016
@lijunle lijunle deleted the arrange-files branch February 27, 2016 23:54
nigelzor pushed a commit to nigelzor/depcheck that referenced this pull request Jan 23, 2018
@lijunle
Merge pull request depcheck#104 from lijunle/mention-es7
c3fc7fc 
Mention ES7 support in README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refinement
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lijunle @codecov-io