Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the peer dependencies as dev dependencies too. #125

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Mar 24, 2016

/cc @LinusU

@lijunle lijunle added this to the 0.6.2 milestone Mar 24, 2016
@LinusU
Copy link
Member

LinusU commented Mar 25, 2016

Isn't the accepted practice that you include your dependencies peer-dependencies as your own dependencies? That is, just adding them as dependencies...

Also, I had a warning about eslint-plugin-react being an unmet peer dependency as well. Maybe that should go on the list also...

@lijunle
Copy link
Member Author

lijunle commented Mar 25, 2016

We do not use eslint-plugin-react in our code. That one is fine to let it leave.

Not everybody use typescript and SASS parser, to whom use them, they will install typescript and SASS parser at project level. That is exactly how peer dependency works.

I have ideas to resolve these failing tests. The idea is to mark them as dev dependencies and peer dependencies.

- They will be installed for development and CI testing.
- Remove them from separated `npm install` in CI config.
@codecov-io
Copy link

Current coverage is 96.12%

Merging #125 into master will not affect coverage as of 2bc0442

@@            master    #125   diff @@
======================================
  Files           23      23       
  Stmts          439     439       
  Branches        85      85       
  Methods          0       0       
======================================
  Hit            422     422       
  Partial          9       9       
  Missed           8       8       

Review entire Coverage Diff as of 2bc0442

Powered by Codecov. Updated on successful CI builds.

@lijunle lijunle changed the title Install the peer dependencies on post-install phrase. Mark the peer dependencies as dev dependencies too. Mar 25, 2016
@lijunle lijunle merged commit 4911df1 into depcheck:master Mar 25, 2016
@lijunle lijunle deleted the install-peer-dep branch March 25, 2016 16:50
@LinusU
Copy link
Member

LinusU commented Mar 25, 2016

Ignore my stupid comment, I thought that it was peer dependencies to one of our dependencies 😆

@lijunle
Copy link
Member Author

lijunle commented Mar 25, 2016

Actually, they are. We depends on their parse function to parse .ts (Typescirpt) files, .sass and .scss (SASS) files. However, I don't want to install everything then the user only use plain JavaScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants