Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gulp plugins loaded by gulp-load-plugins. #127

Merged
merged 7 commits into from
Mar 26, 2016
Merged

Support gulp plugins loaded by gulp-load-plugins. #127

merged 7 commits into from
Mar 26, 2016

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Mar 25, 2016

Related to #18

  • Use babel-traverse to walk through the AST to figure out which packages are loaded by gulp-load-plugins.
  • Add simple test cases to support.
  • Only gulp-* and gulp.* are supported.

@lijunle lijunle added this to the 0.6.2 milestone Mar 25, 2016
@lijunle
Implement to detect gulp plugins from ES6 import
7175fd0 
- The test case about import declaration is passing.
- Leverage the babel-traverse to find out references and calls.
- TODO implement the require pattern logics.

wtf implementation.
@lijunle
Implement the logic for require calls.
85eee0a 
- There are three require call pattern. All are supported.
- Do crazy copy-paste on the code to make it work.
- It is a MUST to do refactor after get all test cases passed.
@lijunle
Do crazy refactor!
f228f6f 
- Avoid code redundant.
- Keep good function structure.
@codecov-io
Copy link

Current coverage is 96.31%

Merging #127 into master will increase coverage by +0.19% as of 368fe9c

@@            master    #127   diff @@
======================================
  Files           23      24     +1
  Stmts          439     515    +76
  Branches        85     101    +16
  Methods          0       0       
======================================
+ Hit            422     496    +74
- Partial          9      10     +1
- Missed           8       9     +1

Review entire Coverage Diff as of 368fe9c

Powered by Codecov. Updated on successful CI builds.

@lijunle
Support gulpfile.babel.js file too.
c7f8c09 
- Add test cases support.
- Most of false alert from web-app is resolved.
@lijunle
Copy link
Member Author

lijunle commented Mar 25, 2016

Still not cover:

  • Package: gulp-sourcemap
  • Code: $.sourcemaps.init()

Update: support it via this commit!

@lijunle
Support gulp plugin used in direct call.
6f6fa3d 
- Add test cases to cover the support.
- Not get plugin name from call, match the call to plugin name.
@lijunle lijunle mentioned this pull request Mar 26, 2016
Closed
@lijunle lijunle merged commit aeaacd0 into depcheck:master Mar 26, 2016
@lijunle lijunle deleted the gulp-load-plugins branch March 26, 2016 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lijunle @codecov-io