Add support for scoped packages in ESLint special. Close #174 #176
Conversation
Current coverage is 98.73% (diff: 100%)@@ master #176 diff @@
==========================================
Files 23 23
Lines 622 634 +12
Methods 156 160 +4
Messages 0 0
Branches 140 142 +2
==========================================
+ Hits 613 626 +13
+ Misses 9 8 -1
Partials 0 0
|
goloroden
changed the title
goloroden
changed the title
|
PS: Node.js 0.12 tests pass, but running depcheck on itself doesn't work on this version of Node.js. With 4.x and 6.x, everything is fine. To be honest, I do not actually know why this is :-( |
| } | ||
|
|
||
| function isEslintConfigARelativePath(specifier) { | ||
| // return !/\w|@/.test(preset.charAt(0)); |
There was a problem hiding this comment.
Could you please clean up this comment?
There was a problem hiding this comment.
Done (and sorry for having forgotten to remove this one).
| function resolvePresetPackage(preset, rootDir) { | ||
| // inspired from https://github.com/eslint/eslint/blob/5b4a94e26d0ef247fe222dacab5749805d9780dd/lib/config/config-file.js#L347 |
There was a problem hiding this comment.
Please don't remove this inspired comment. It is a clue for future updates.
| { | ||
| name: 'handle config of scoped module with full name', | ||
| content: { | ||
| extends: '@my-org/eslint-config-customized', |
There was a problem hiding this comment.
Could you please switch another random name here? Or code is search friendly.
Thanks a lot, that's very nice feedback 馃槉
I updated all three sections.
Thanks! |
|
I get the reason that node 0.12 is failing, see this log: https://travis-ci.org/depcheck/depcheck/jobs/177059242#L614 node 0.12 not support String.prototype.startsWith. |
- Resolve the build failing in node 0.12.x
|
Awesome, thanks :-) |
|
@goloroden Version 0.6.5 is out, please enjoy it! Thank you again for contributing! |
|
Great news, thanks again 馃槉 |
Hi @lijunle 馃槉
I have added support for scoped modules. I did not follow the new ESLint code, but rather cleaned up the existing one and added what was needed to make things work with scoped modules.
I hope you like it 馃槉