add: support for require.resolve in JS #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, could you confirm the eslint rules? It is asking for trailing comma explicitly. |
Current coverage is 98.14% (diff: 100%)@@ master #196 diff @@
==========================================
Files 23 24 +1
Lines 431 432 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 423 424 +1
Misses 8 8
Partials 0 0
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases of simple plugin registration, we use
require.resolvewhich should also be processed by depcheck.