A new detector to discover express view engine #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 98.14% 98.15% +<.01%
==========================================
Files 24 25 +1
Lines 432 433 +1
==========================================
+ Hits 424 425 +1
Misses 8 8
Continue to review full report at Codecov.
|
|
@lijunle Could you review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements a new detector
expressViewEngine.I don't add this detector to default options because I'm not sure if it should be enable by default.
The current test tool doesn't support giving
detectorsinoptionsinspec.js. I have to modify it a bit. A tricky thing is that a naming rule is required for detectors to make cli test works: function name must be the same as its public name defined incomponent.json.