Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in README.md --ignores flag explanation #224

Merged
merged 2 commits into from
Oct 13, 2017

Conversation

leopoldjoy
Copy link
Contributor

add missing asterisks around --ignores flag arguments to make them glob expressions

@lijunle
Copy link
Member

lijunle commented Oct 10, 2017

Hi, @leopoldjoy

Thank you for raising this up. I think your concern is, the example does not show the glob example. Is that right?

For demonstration reason, it could better to have one with and one without glob. How about this - --ignores=eslint,babel-*?

add example of glob expression to --ignores flag arguments
@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #224 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          25       25           
  Lines         447      447           
=======================================
  Hits          440      440           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fca26...840f6c6. Read the comment docs.

@leopoldjoy
Copy link
Contributor Author

@lijunle Exactly, I felt it would be useful to show the glob example. I agree with you about showing both, I have updated this PR accordingly.

Copy link
Member

@lijunle lijunle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lijunle lijunle merged commit 2666a2e into depcheck:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants