Add ability to skip calculation of missing dependencies #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 98.43% 98.43% +<.01%
==========================================
Files 25 25
Lines 447 448 +1
==========================================
+ Hits 440 441 +1
Misses 7 7
Continue to review full report at Codecov.
|
lijunle
approved these changes
Feb 12, 2018
| `--json`: Output results in JSON. When not specified, depcheck outputs in human friendly format. | ||
|
|
||
| `--ignores`: A comma separated array containing package names to ignore. It can be glob expressions. Example, `--ignores=eslint,babel-*`. | ||
| `--ignores`: A comma separated array containing package names to ignore. It can be glob expressions. Example, `--ignores="eslint,babel-*"`. |
|
@tSte Do you want me to publish a new version for this? |
|
@lijunle I hope I didn't break anything... ;) |
|
@tSte I have high confidence with the test cases. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, you don't care about missing dependencies. While non-empty missing dependencies do not seem to affect CLI exit code, this might change in the future (#235).
This PR adds simple flag to both JS (
skipMissing) and CLI (--skip-missing). It is optional (defaults tofalse- the original behavior).Todo: