use eslint name normalization

[43081j]

It is possible in ESLint to have plugins in the following formats:

[
  "@foo/eslint-plugin",
  "@foo",
  "bar",
  "eslint-plugin-bar"
]

We currently only support the last two in depcheck, which leads to some freaky errors:

Missing dependencies: { 'eslint-plugin-@typescript-eslint/eslint-plugin':

I took the function as-is from eslint and left a jsdoc link to it.

[43081j]

Duplicate of #234 apparently, my mistake.

Though the implementation at #234 doesn't use eslint's own normalisation function and probably should instead of re-inventing the wheel and potentially having different behaviour.

[rumpl]

Build failed because the copy/pasted code from eslint makes eslint check fail, I think that's beautiful.

Could you take a look and resolve the issues please?

[codecov]

Codecov Report

Merging #305 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   98.05%   98.11%   +0.06%     
==========================================
  Files          30       30              
  Lines         462      477      +15     
==========================================
+ Hits          453      468      +15     
  Misses          9        9

Impacted Files	Coverage Δ
src/utils/linters.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a09a06...19d86eb. Read the comment docs.

[43081j]

sorry about that, the shame of not running lint before pushing 😞

[43081j]

@rumpl mind having another look at this?

[rumpl]

There are two checks failing for this PR, could you add some more tests so that the codecov is happy please? You can see the code not covered by tests here.

Thanks for contributing! ;)

[43081j]

sorry totally didn't see the check somehow. should be sorted now

[rumpl]

Thanks for this!

I'll try (very hard this time) to review the other PRs and maybe make a new release.

Cheers

[lijunle]

@rumpl it is great that you have a new job and continue on this project! 😋

[rumpl]

Thanks @lijunle :)