Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sass support for tilde #323

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Add sass support for tilde #323

merged 2 commits into from
Feb 28, 2019

Conversation

KaboomFox
Copy link
Member

Fixes issue #322 False reports from scss files with @import ~package-in-node_module/main.css

KaboomFox
KaboomFox commented Feb 28, 2019
View reviewed changes
package-lock.json
@@ -929,19 +929,22 @@
"version": "4.0.0",
"resolved": "https://registry.npmjs.org/arr-diff/-/arr-diff-4.0.0.tgz",
"integrity": "sha1-1kYQdP6/7HHn4VI1dhoyml3HxSA=",
"dev": true
"dev": true,
"optional": true
Copy link
Member Author

@KaboomFox KaboomFox Feb 28, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file fixes high severity vulnerability found by npm audit.

@rumpl
Copy link
Member

rumpl commented Feb 28, 2019

Hey @KaboomFox, thanks for making this PR, could you just address the linting problem that makes the build fail?

@KaboomFox
Copy link
Member Author

@rumpl will fix! Thanks!

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #323 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          32       32           
  Lines         561      561           
=======================================
  Hits          552      552           
  Misses          9        9
Impacted Files Coverage Δ
src/parser/sass.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f424860...1f2c1a9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 28, 2019 •
edited

Codecov Report

Merging #323 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          32       32           
  Lines         561      561           
=======================================
  Hits          552      552           
  Misses          9        9
Impacted Files Coverage Δ
src/parser/sass.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f424860...1f2c1a9. Read the comment docs.

@rumpl rumpl merged commit b016a96 into depcheck:master Feb 28, 2019
@rumpl
Copy link
Member

rumpl commented Feb 28, 2019

Thanks!

@rumpl
Copy link
Member

rumpl commented Feb 28, 2019

Version 0.7.2 with tilde is on npm now, thanks @KaboomFox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumpl rumpl rumpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KaboomFox @rumpl