Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use file instead of content. #324

Merged
merged 2 commits into from
Mar 1, 2019
Merged

use file instead of content. #324

merged 2 commits into from
Mar 1, 2019

Conversation

KaboomFox
Copy link
Member

@KaboomFox KaboomFox commented Mar 1, 2019

Fixes false positive for characters in sass files that renderSync has issues parsing.

In node-sass

if (options.data) {
    status = binding.renderSync(options);
  } else if (options.file) {
    status = binding.renderFileSync(options);

renderSync has issues with some characters and errors with:

  at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:408:3)
        status: 1,
        file: 'stdin',
        line: 1,
        column: 9,
        message: 'returned value of `file` must be a string',
        formatted: 'Error: returned value of `file` must be a string\n        on line 1 of stdin\n>> @import "~react-vis/dist/main.scss";\n\n   --------^\n' 

By changing it to read the file instead it avoids this issue.

@KaboomFox
Copy link
Member Author

Sorry I didn't get this in in-time for the release this morning!

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #324   +/-   ##
======================================
  Coverage    98.4%   98.4%           
======================================
  Files          32      32           
  Lines         563     563           
======================================
  Hits          554     554           
  Misses          9       9
Impacted Files Coverage Δ
src/parser/sass.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75fc166...0892004. Read the comment docs.

@rumpl rumpl merged commit 3190ced into depcheck:master Mar 1, 2019
@rumpl
Copy link
Member

rumpl commented Mar 1, 2019

Thanks! I'll wait some more this time for a release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants