Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make walkdir follow symlinks #347

Merged
merged 4 commits into from
May 9, 2019
Merged

feat: Make walkdir follow symlinks #347

merged 4 commits into from
May 9, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented May 9, 2019

Adding a test for:

  • file symlinks
  • directory symlinks

Fixes #256

Adding a test for:
- file symlinks
- directory symlinks

Fixes #256
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          33       33           
  Lines         640      640           
=======================================
  Hits          632      632           
  Misses          8        8
Impacted Files Coverage Δ
src/check.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a87793...0761c40. Read the comment docs.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          33       33           
  Lines         640      640           
=======================================
  Hits          632      632           
  Misses          8        8
Impacted Files Coverage Δ
src/check.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a87793...95fdcd8. Read the comment docs.

@rumpl rumpl merged commit beae930 into master May 9, 2019
@rumpl rumpl deleted the feat-follow-symlinks branch May 13, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symlinked files are ignored
1 participant