Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support flow syntax in es7 and jsx parsers #373

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

jrnail23
Copy link
Contributor

@jrnail23 jrnail23 commented Jul 9, 2019

resolves #353
This PR adds babel's flow parsing to es7 and jsx parsers.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          34       34           
  Lines         687      687           
=======================================
  Hits          679      679           
  Misses          8        8
Impacted Files Coverage Δ
src/parser/jsx.js 100% <ø> (ø) ⬆️
src/parser/es7.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbd86b...17f9e4a. Read the comment docs.

Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rumpl rumpl merged commit e080198 into depcheck:master Jul 9, 2019
@jrnail23
Copy link
Contributor Author

jrnail23 commented Jul 9, 2019

@rumpl, thanks for taking this PR so quickly! Any idea when you might publish the new version?

@jrnail23 jrnail23 deleted the flow-parsing branch July 9, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid files caused by flow type annotations?
2 participants