Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier #463

Merged
merged 3 commits into from
Nov 3, 2019
Merged

Add prettier #463

merged 3 commits into from
Nov 3, 2019

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Nov 3, 2019

I made some try to find the rules already use for this project:

  • singleQuote over doubleQuote
  • arrowParens always
  • trailingComma

@VincentLanglet VincentLanglet mentioned this pull request Nov 3, 2019
@VincentLanglet
Copy link
Contributor Author

@rumpl Funny,

I got

Unused devDependencies
* eslint-config-prettier

But i use it, see https://github.com/prettier/eslint-plugin-prettier#recommended-configuration

plugin:prettier/recommended is enough.

@rumpl
Copy link
Member

rumpl commented Nov 3, 2019

Damn... I guess we will need a special case for this prettier plugin...

@rumpl
Copy link
Member

rumpl commented Nov 3, 2019

Just opened a PR #464

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #463 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   99.17%   99.18%   +<.01%     
==========================================
  Files          38       38              
  Lines         731      737       +6     
==========================================
+ Hits          725      731       +6     
  Misses          6        6
Impacted Files Coverage Δ
src/parser/jsx.js 100% <ø> (ø) ⬆️
src/special/mocha.js 100% <ø> (ø) ⬆️
src/parser/vue.js 75% <ø> (ø) ⬆️
src/constants.js 100% <ø> (ø) ⬆️
src/cli.js 100% <100%> (ø) ⬆️
src/special/husky.js 100% <100%> (ø) ⬆️
src/detector/typescriptImportEqualsDeclaration.js 100% <100%> (ø) ⬆️
src/special/gatsby.js 100% <100%> (ø) ⬆️
src/detector/requireCallExpression.js 100% <100%> (ø) ⬆️
src/special/eslint.js 100% <100%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6135bb0...ff0d2ad. Read the comment docs.

@rumpl rumpl merged commit 9240474 into depcheck:master Nov 3, 2019
@rumpl
Copy link
Member

rumpl commented Nov 3, 2019

Awesome thanks @VincentLanglet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants