Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return error code even if output is json #465

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Nov 3, 2019

Closes #407

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #465 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          38       38           
  Lines         740      740           
=======================================
  Hits          734      734           
  Misses          6        6
Impacted Files Coverage Δ
src/cli.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83aa291...38ccf4e. Read the comment docs.

@rumpl rumpl merged commit dff7ebb into master Nov 3, 2019
@rumpl rumpl deleted the feat-consistent-exit-code branch November 3, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option --json changes return status
1 participant