Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate building of TypeScript definitions #470

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Automate building of TypeScript definitions #470

merged 1 commit into from
Nov 5, 2019

Conversation

sveyret
Copy link
Contributor

@sveyret sveyret commented Nov 4, 2019

Because I almost forgot to update index.d.ts last time I added a special parser, I modified the component.js script in order to make it possible to rebuild this index.d.ts file.

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #470 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          39       39           
  Lines         761      761           
=======================================
  Hits          755      755           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ebbfc...004397b. Read the comment docs.

@sveyret sveyret changed the title Automate building of TypeScript definitions WIP: Automate building of TypeScript definitions Nov 4, 2019
@sveyret sveyret changed the title WIP: Automate building of TypeScript definitions Automate building of TypeScript definitions Nov 4, 2019
@@ -43,46 +43,7 @@ declare namespace depcheck {
[filePath: string]: any;
};
}

Copy link
Member

@rumpl rumpl Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not normal is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. Instead of directly writing the list of parsers, detectors and specials, the index is now a template, and the component.js script is completing it with all the files found in appropriate directories, just the same way it is creating the component.json file.
If you are specifically talking about the empty line, each group (parser, detector and special) is written starting with an empty line. If you run npm run component, you will see that the generated dist/index.d.ts is the same as the previous index.d.ts (at least, it should be!)

@rumpl rumpl merged commit dcb186f into depcheck:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants