Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ESLint special parser functions. #61

Merged
merged 4 commits into from
Nov 20, 2015
Merged

Improve ESLint special parser functions. #61

merged 4 commits into from
Nov 20, 2015

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Nov 20, 2015

  • Resolve eslint support issues #58
  • Most of the eslint config cases are handled - if the config declares its plugins in its peer or optional dependencies.
  • However, using scoped package as config is not supported yet. Open an issue if you have ideas.

@lijunle
Switch the eslint test case to new pattern.
e1b862e 
- Resolve base on peerDependencies.
- Remove some no-meaning test cases.
@lijunle
Update the logic about ESLint special to discover deps from package.j…
fc135f1 
…son.

- No need to special treat standard config now.
- However, aribnb not declare its optional dependency to its package.json.
@lijunle
Abstract the ESLint special test logic as separated function.
54eb97d
@lijunle lijunle changed the title Improve ESLint special parser handling cases. Improve ESLint special parser functions. Nov 20, 2015
@codecov-io
Copy link

Current coverage is 97.50%

Merging #61 into master will decrease coverage by -0.26% as of f69146c

@@            master    #61   diff @@
=====================================
  Files           11     11       
  Stmts          269    280    +11
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit            263    273    +10
  Partial          0      0       
- Missed           6      7     +1

Review entire Coverage Diff as of f69146c

Powered by Codecov. Updated on successful CI builds.

lijunle added a commit that referenced this pull request Nov 20, 2015
@lijunle
Merge pull request #61 from lijunle/refine-eslint
86473e9 
Improve ESLint special parser functions.
@lijunle lijunle merged commit 86473e9 into depcheck:master Nov 20, 2015
@lijunle lijunle deleted the refine-eslint branch November 20, 2015 18:30
gtanner pushed a commit to gtanner/depcheck that referenced this pull request Jan 19, 2016
@lijunle
Merge pull request depcheck#61 from lijunle/not-ignore-bin
9269172 
Add ignore-bin-package switch to options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lijunle @codecov-io