Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove punycode from the buildin modules #629

Merged
merged 1 commit into from Mar 18, 2021
Merged

Remove punycode from the buildin modules #629

merged 1 commit into from Mar 18, 2021

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Mar 18, 2021

Fixes #628

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #629 (b92e569) into main (264ac54) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          48       48           
  Lines        1009     1009           
=======================================
  Hits          995      995           
  Misses         14       14           
Impacted Files Coverage Δ
src/check.js 100.00% <ø> (ø)
src/utils/typescript.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddfcac...b92e569. Read the comment docs.

Copy link

@jdrouet jdrouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumpl rumpl merged commit 36c73d9 into main Mar 18, 2021
@rumpl rumpl deleted the fix-punycode branch March 18, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

punycode being listed as unused, although the built in version is deprecated
2 participants