Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the bin special parser to be stable. #64

Merged
merged 6 commits into from
Nov 21, 2015

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Nov 20, 2015

  • It supports $(npm bin)/binary-entry style command
  • It supports command prefixed with environment variable set.
  • Test cases are refactored to be data-driven + test helper pattern.
  • Currently, the identification bases on space split word matching.

@codecov-io
Copy link

Current coverage is 97.56%

Merging #64 into master will increase coverage by +0.05% as of f84fd4f

@@            master     #64   diff @@
======================================
  Files           12      12       
  Stmts          282     287     +5
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            275     280     +5
  Partial          0       0       
  Missed           7       7       

Review entire Coverage Diff as of f84fd4f

Powered by Codecov. Updated on successful CI builds.

lijunle added a commit that referenced this pull request Nov 21, 2015
Refine the bin special parser to be stable.
@lijunle lijunle merged commit 092b985 into depcheck:master Nov 21, 2015
@lijunle lijunle deleted the fix-npm-bin branch November 21, 2015 05:40
gtanner pushed a commit to gtanner/depcheck that referenced this pull request Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants