Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore paths #8

Merged
merged 6 commits into from
Jun 14, 2014
Merged

Ignore paths #8

merged 6 commits into from
Jun 14, 2014

Conversation

dylang
Copy link
Contributor

@dylang dylang commented Jun 11, 2014

did it on the plane, changed a bunch of stuff (sorry!), should be working, tests pass. plane is landing now so i have to stop.

@dylang
Copy link
Contributor Author

dylang commented Jun 11, 2014

This PR address #6, #7, and #8.

@@ -1,4 +1,4 @@
language: node_js
node_js:
- '0.10'
- '0.8'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out with the old, in with the new!

@dylang
Copy link
Contributor Author

dylang commented Jun 14, 2014

I'd like to publish an update to npm-check that will require the changes from this PR.

If these changes were more than you were expecting and you don't want to accept them because the code is too different I totally understand. If that's the case, would it be okay if I use my PR to create a new module? I'll give you credit as the original author in the readme and code.

rumpl added a commit that referenced this pull request Jun 14, 2014
@rumpl rumpl merged commit b331ea0 into depcheck:master Jun 14, 2014
@rumpl
Copy link
Member

rumpl commented Jun 14, 2014

Sorry, for the delay :(

@rumpl
Copy link
Member

rumpl commented Jun 14, 2014

I just published the 0.4.0 version on npm with your changes.
Thank you for taking the time to make this PR.

Once again, sorry it took me so long to merge this one.
I will try to be faster next time :)

@dylang
Copy link
Contributor Author

dylang commented Jun 14, 2014

Awesome, no worries! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants