Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Babel presets/plugins from scoped packages #808

Merged
merged 4 commits into from Jul 17, 2023

Conversation

miluoshi
Copy link
Collaborator

Babel name normalization docs: https://babeljs.io/docs/options#name-normalization

Fixes #719

[Babel name normalization docs](https://babeljs.io/docs/options#name-normalization) allow references to file paths within a package:
> References to files within a package are untouched.
@miluoshi
Copy link
Collaborator Author

Pipeline is failing for Node 14.x because .at() method at builtin indexables is available since Node 16.8.0.

depcheck:checkFile:error depcheck/.babelrc [AsyncFunction: parseBabel] TypeError: scopeMatch.at is not a function
    at contain (depcheck/dist/special/babel.js:46:102)

According to Node release schedule v14 is not maintained anymore and so should not be supported.

@miluoshi
Copy link
Collaborator Author

I've removed Node 14 from the node workflow just to test that checks work in newer versions. I can remove the commit if you want to keep support for Node 14

@rumpl rumpl merged commit 8ead447 into depcheck:main Jul 17, 2023
3 checks passed
@karlhorky
Copy link
Contributor

Thanks for the PR @miluoshi and merge @rumpl ! 🙌

@rumpl @znarf Any chance we could get a new release + publish to npm with this (also including #773 )?

@karlhorky
Copy link
Contributor

Ahh, maybe @rumpl is going for trying out the automatic publishing, once it gets merged in this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support babel preset scope shorthand
3 participants