Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic import with a template literal #779 #810

Merged
merged 1 commit into from Jul 17, 2023
Merged

Fix dynamic import with a template literal #779 #810

merged 1 commit into from Jul 17, 2023

Conversation

ArtskydJ
Copy link
Contributor

Depcheck doesn't catch this

import(`whatever`)

But with this PR, it now will catch that import.

znarf
znarf approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@znarf znarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance.

@rumpl rumpl merged commit 83e9f54 into depcheck:main Jul 17, 2023
4 checks passed
@ArtskydJ ArtskydJ deleted the fix-dynamic-import-template-literal branch August 15, 2023 04:07
@ArtskydJ ArtskydJ mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znarf znarf znarf approved these changes

@rumpl rumpl rumpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArtskydJ @znarf @rumpl