Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix peer dependencies from nested files not detected. #82

Merged
merged 2 commits into from
Dec 2, 2015
Merged

Fix peer dependencies from nested files not detected. #82

merged 2 commits into from
Dec 2, 2015

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Dec 2, 2015

Resolve #81

@lijunle
Add test about nested peer dependencies check.
d9cb39e 
- Reflect depcheck#81
- It is failing.
@lijunle
Fix the nested peer dependencies issue.
487b3be 
- Pass test case.
- TODO: refine the code parameters, clean up useless.
@codecov-io
Copy link

Current coverage is 97.38%

Merging #82 into master will decrease coverage by -0.67% as of 487b3be

@@            master     #82   diff @@
======================================
  Files           14      14       
  Stmts          309     306     -3
  Branches        70      69     -1
  Methods          0       0       
======================================
- Hit            303     298     -5
- Partial          4       5     +1
- Missed           2       3     +1

Review entire Coverage Diff as of 487b3be

Powered by Codecov. Updated on successful CI builds.

lijunle added a commit that referenced this pull request Dec 2, 2015
@lijunle
Merge pull request #82 from lijunle/fix-subdir
4c77b76 
Fix peer dependencies from nested files not detected.
@lijunle lijunle merged commit 4c77b76 into depcheck:master Dec 2, 2015
@lijunle lijunle deleted the fix-subdir branch December 2, 2015 14:57
gtanner pushed a commit to gtanner/depcheck that referenced this pull request Jan 19, 2016
@lijunle
Merge pull request depcheck#84 from mathieudutour/f/deps-regex-coffee
01410a4 
Support CoffeeScript.

Resolve depcheck#84, Close depcheck#82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lijunle @codecov-io